Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(release.md): add blog announcement to post-release tasks #1652

Merged
merged 3 commits into from
May 18, 2021
Merged

docs(release.md): add blog announcement to post-release tasks #1652

merged 3 commits into from
May 18, 2021

Conversation

maxgio92
Copy link
Member

@maxgio92 maxgio92 commented May 14, 2021 •
edited by leogr
Loading

What type of PR is this?

/kind documentation

Any specific area of the project related to this PR?

none

What this PR does / why we need it:

This PR documents blog announcement as part of post-release tasks.

NONE

@maxgio92
docs(release.md): add blog announcement to post-release tasks
4d6b316 
Signed-off-by: maxgio92 <massimiliano.giovagnoli.1992@gmail.com>
@poiana poiana requested review from fntlnz and mstemm May 14, 2021 11:18
@poiana poiana added the size/XS label May 14, 2021
@maxgio92
Copy link
Member Author

/assign @leogr

leogr
leogr reviewed May 14, 2021
View reviewed changes
Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would also add a placeholder to mention the release manager to the release template.
(as we did here https://github.com/falcosecurity/falco/releases/tag/0.28.1)

RELEASE.md Outdated Show resolved Hide resolved
@leogr leogr added this to the 0.28.2 milestone May 14, 2021
@maxgio92
docs(release.md): update post-release tasks order
70b5ca8 
Signed-off-by: maxgio92 <massimiliano.giovagnoli.1992@gmail.com>
@maxgio92
Copy link
Member Author

maxgio92 commented May 14, 2021 •
edited
Loading

I would also add a placeholder to mention the release manager to the release template.
(as we did here https://github.com/falcosecurity/falco/releases/tag/0.28.1)

Sure, thanks. Updated accordingly in #13cfa

@maxgio92
docs(release.md): update github release template mentioning the relea…
13cfa1a 
…se manager

Signed-off-by: maxgio92 <massimiliano.giovagnoli.1992@gmail.com>
leogr
leogr approved these changes May 14, 2021
View reviewed changes
Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Thank you, Max :)

@poiana poiana added the lgtm label May 14, 2021
@poiana
Copy link
Contributor

poiana commented May 14, 2021

LGTM label has been added.

Git tree hash: 2ef80bf7eb98b890e6657267f699d53a6b9d6bd3

@leogr
Copy link
Member

leogr commented May 18, 2021

/approve

@poiana
Copy link
Contributor

poiana commented May 18, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 59831b0 into falcosecurity:master May 18, 2021
@maxgio92 maxgio92 mentioned this pull request May 18, 2021
Closed
12 tasks
@leogr leogr modified the milestones: 0.28.2, 0.29.0 Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leogr leogr leogr approved these changes

@leodido leodido leodido approved these changes

@fntlnz fntlnz Awaiting requested review from fntlnz

@mstemm mstemm Awaiting requested review from mstemm

Assignees

@leodido leodido

@leogr leogr

Labels
approved dco-signoff: yes kind/documentation lgtm release-note-none size/XS
Projects
None yet
Milestone
0.29.0
Development

Successfully merging this pull request may close these issues.
4 participants
@maxgio92 @poiana @leogr @leodido